Skip to content

table view: fix link clicks on table rows and change icon on Settings button#1747

Merged
lyubov-voloshko merged 3 commits into
mainfrom
mini-fixes
Apr 30, 2026
Merged

table view: fix link clicks on table rows and change icon on Settings button#1747
lyubov-voloshko merged 3 commits into
mainfrom
mini-fixes

Conversation

@lyubov-voloshko
Copy link
Copy Markdown
Collaborator

@lyubov-voloshko lyubov-voloshko commented Apr 29, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where clicking edit or duplicate action links on table rows would inadvertently trigger the row click handler.

  • UI Updates

    • Updated the settings dropdown trigger icon for improved visual consistency.

Copilot AI review requested due to automatic review settings April 29, 2026 12:11
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59a1b923-4cd6-4dd6-8fce-13bf287a2532

📥 Commits

Reviewing files that changed from the base of the PR and between 45bdcb6 and 26c289c.

📒 Files selected for processing (1)
  • frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html
📝 Walkthrough

Walkthrough

Updated the settings dropdown trigger icon from more_vert to material-symbols-outlined settings icon. Modified the edit and duplicate action link handlers to invoke $event.stopPropagation() before executing stashUrlParams() and PostHog capture events, preventing unintended row click handler activation.

Changes

Cohort / File(s) Summary
Dashboard Table View Template
frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html		 Changed settings dropdown icon from more_vert to material-symbols-outlined "settings". Added $event.stopPropagation() calls to edit and duplicate action links to prevent row click event bubbling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 The table now stops its bubbling cascade,
Each action click, a careful hand-made
Settings icon gleams with symbol's grace,
Event propagation halts in place! ✨

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the two main changes: fixing link clicks on table rows and changing the Settings button icon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed Pull request makes template-level changes adding event.stopPropagation() to action buttons and updating icons, with no input validation issues, data sanitization problems, or introduction of OWASP vulnerabilities like XSS, CSRF, or injection attacks.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mini-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dashboard table view to improve row interaction behavior and align the Settings menu trigger icon with the intended UX.

Changes:

  • Replaces the settings dropdown trigger icon with a material-symbols-outlined “settings” icon.
  • Prevents row-click handlers from firing when clicking the “Edit row” and “Duplicate row” action links by stopping event propagation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html
Comment on lines 149 to 156
<button mat-icon-button type="button"
*ngIf="canEditConnection()"
[matMenuTriggerFor]="settingsMenu"
angulartics2On="click"
angularticsAction="Dashboard: settings dropdown is clicked"
(click)="posthog.capture('Dashboard: settings dropdown is clicked')">
<mat-icon>more_vert</mat-icon>
<mat-icon fontSet="material-symbols-outlined">settings</mat-icon>
</button>
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings menu trigger is an icon-only mat-icon-button without an accessible name (no aria-label/aria-labelledby). Since <mat-icon> is typically aria-hidden, screen readers may announce this as an unlabeled button. Add an aria-label (and optionally a tooltip) describing the action (e.g., "Settings").

Copilot uses AI. Check for mistakes.
@lyubov-voloshko lyubov-voloshko merged commit b6a14ea into main Apr 30, 2026
15 of 16 checks passed
@lyubov-voloshko lyubov-voloshko deleted the mini-fixes branch April 30, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lyubov-voloshko